Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-20754 - Clear memory leak in CSV CLI import #10537

Merged
merged 3 commits into from
Jul 17, 2017
Merged

CRM-20754 - Clear memory leak in CSV CLI import #10537

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c07d16
CRM-20754 - Clear memory leak in CSV CLI import
MegaphoneJon Jun 21, 2017
0d37904
style fix
MegaphoneJon Jun 22, 2017
39a545d
Use the freeResult DAO method
MegaphoneJon Jul 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bin/cli.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,10 @@ public function run() {
continue;
}
$this->row++;
if ($this->row % 1000 == 0) {
// Reset PEAR_DB_DATAOBJECT cache to prevent memory leak
CRM_Core_DAO::freeResult();
}
$params = $this->convertLine($data);
$this->processLine($params);
}
Expand Down