CRM-20740 - Fix issue with check for custom_nn => ['IS NULL' => 1]. #10512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 15, 2017 22:02
But since I have no working dev environment for the moment, I cannot run it myself. I will push it, and see if it passes. (If someone can check whether the tests fails on master, that would be very nice.)
|
@johanv is there any reason why using a LEFT OUTER join rather than just a straight LEFT JOIN for when testing for NULL? |
|
No. I thought that LEFT JOIN and LEFT OUTER JOIN were equivalent. |
|
just did a quick google and your right no worries mate @johanv |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix for CRM-20740. Using the API to retrieve entities with a custom field that IS NULL, now also works when there are entities without custom values in the custom field set.
A test would be nice. If I find the time, I will create one.