CRM-20718 CIVICRM-125 Use the "On behalf of" profile title... #10499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t title on Contribution pages instead of hardcoded title "Organization Details"
| @@ -893,7 +893,7 @@ public function buildComponentForm($id, $form) { | |||
| } | |||
| } | |||
|
|
|||
| $form->assign('fieldSetTitle', ts('Organization Details')); | |||
| $form->assign('fieldSetTitle', CRM_Core_BAO_UFGroup::getTitle($form->_values['onbehalf_profile_id'])); | |||
There was a problem hiding this comment.
It seems that ts() on Organization Details was displaying the converted string for each language. This seems to be working fine with the intention of the issue. But the organization title will only be shown in English after this change. Any reason of not passing the title to ts() before assigning to $form ?
There was a problem hiding this comment.
@jitendrapurohit sure, why not :) Updated PR.
|
Makes sense to me |
jitendrapurohit
approved these changes
Jun 14, 2017
|
@mlutfy Mathieu does this makes sense to you? |
|
@eileenmcnaughton are you able to review this small change? |
|
Makes sense & reviewed by @jitendrapurohit - merging. Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the "On behalf of" profile title as fieldset title