CRM-20243 Remove outdated sample jquery.min.js from phpword package #10495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems safe enough. Would phpoffice work if we removed the entire folder |
|
@totten not sure, i just aimed to hit the specific JS as that seemed the most of concern |
|
Reading the code in the |
|
@totten i believe i have now updated it correctly to remove everything in the samples folder |
|
Is exception misspelled in this composer.json, or maybe the script file name itself "pear-execption" ? |
|
@jackrabbithanna in the script name should get fixed in #10384 |
1af289a to
7097681
Compare
|
@totten i have rebased this now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @totten @xurizaemon