CRM-19610 : Search preferences changes are not updated #10491
Conversation
seamuslee001
commented
Jun 11, 2017
•
- CRM-19610: Fatal when creating InnoDB fts indexes
|
@jitendrapurohit i have made some changes to your PR and rebased it, I think the tests will pass now, Can you check to see if it makes sense to you? |
Civi/Core/SettingsBag.php
Outdated
| @@ -352,7 +352,7 @@ protected function setDb($name, $value) { | |||
| } | |||
| $dao->find(TRUE); | |||
|
|
|||
| if (isset($metadata['on_change'])) { | |||
| if (isset($metadata['on_change']) && !($value === 0 && ($dao->value === NULL || unserialize($dao->value) === 0))) { | |||
There was a problem hiding this comment.
Thanks @seamuslee001. It passes the test now but the main issue seems to be appearing after this change. As $value is supposed to be of type mixed in this function, === will always fail for '0' if passed as a string.
|
@jitendrapurohit i have altered the check to allow for possibility of '0' and locally tests are still passing, I note that your most recent change still fails the tests. I'm just not 100% sure if my logic is correct and don't know why mine would pass but yours wouldn't |
|
ping @eileenmcnaughton @totten |
|
This seems fine to me - note there is an open critical issue that would be probably fixed by this too. I think @nganivet logged it some time back? |
|
Ah - linked JIRA issue is wrong? |
|
@eileenmcnaughton nope correct i believe its the same as Jitendra's and #10453 should be merged as well |