CRM-20680 Spin the Civi logo when navigating between pages #10465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
awestuk
commented
Jun 3, 2017
•
- CRM-20680: Make the CiviCRM logo spin while waiting for next page to load
|
Can one of the admins verify this patch? |
|
@civicrm-builder add to whitelist |
|
I tested the patch and works for me. To clarify: after the user clicks on a menu item of the CiviCRM menu (at the top of the screen), or any link that causes a full page reload, it makes the civi logo (in the top menu bar) spin (until the new page load starts). It's a nice distraction when waiting for a page load, and provides similar feedback to most modern apps (especially react/redux) who usually have some sort of bar showing the page load status. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.