CRM-20642 - Activity.get - Fix "IS NULL" filtering for case_id, tag_id, file_id #10451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CRM-20642 requires an option for displaying "activities which are *not* case-related" (i.e. `case_id IS NULL`) . This adds a unit-test for ensuring that the filter works as expected.
totten
added a commit
to totten/org.civicrm.civicase
that referenced
this pull request
Jun 1, 2017
In the "display options", this conditionally adds a checkbox "Show case activities". Contingencies: * If the `ActivityFeed` is embedded within a case, then the `Activity.get` query filters on `case_id = civicrm#123`, and the option "Show case activities" is not available. * If "Show case activities" is enabled, then the `Activity.get` query does not filter on `case_id`. (Case and non-case activities are displayed.) * If "Show case activities" is disabled, then the `Activity.get` query filters on `case_id IS NULL`. (Only non-case activities are displayed.) Depends on civicrm/civicrm-core#10451 for correct results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
You could call
Activity.getwith the fieldcase_id,tag_id, orfile_id. The field could specify a number or an array (e.g.array('IS NOT NULL'=>1)orarray('>'=>100)).Before
Specifying a filter like
case_id => array('IS NULL'=>1)was meaningless. It led to an incorrect subquery.After
IS NULLfiltering leads to aLEFT JOINandWHERE the_column IS NULL.Acceptance Criteria
IS NULLalso work.