Fix CRM-20660: Total Opens should count without DISTINCT keyword. #10443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removing "WIP' prefix now that all checks have passed. This is ready for review. |
CRM/Report/Form/Mailing/Summary.php
Outdated
| } | ||
| else { | ||
| $distinct = ''; | ||
| } |
There was a problem hiding this comment.
can we remove else part and initialize $distinct variable above if condition ?
CRM/Report/Form/Mailing/Summary.php
Outdated
| // is the key in $this->_columns, and $fieldName is the key in that array's | ||
| // ['fields'] array. | ||
| // Reference: CRM-20660 | ||
| $distinct_count_columns = array( |
There was a problem hiding this comment.
Can you please change this to satisfy civi-coding standards(camelCase). It would also be nice to fix $count_tables above.
There was a problem hiding this comment.
Funny, I wasn't aware of that part of the standard, somehow. Done.
jitendrapurohit
approved these changes
Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP until all checks pass.