CRM-20226: Parent Group do not inherit child group contacts #10428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
monishdeb
commented
May 27, 2017
•
- CRM-20226: Parent Group do not inherit child group contacts
|
@monishdeb test failure looks related |
|
Thanks @seamuslee001 . Fixed it |
9dd31f3 to
19ed7c5
Compare
|
ran through some tests and this looks good. working as expected now. |
colemanw
requested changes
Jun 6, 2017
| $values[$dao->group_id]['count'] = $dao->count; | ||
| } | ||
| // get group contact count using Contact.GetCount API | ||
| $values[$object->id]['count'] = civicrm_api3('Contact', 'getcount', array('group' => $object->id)); |
There was a problem hiding this comment.
@monishdeb are you sure this doesn't hit the limit = 25 bug in the api3?
There was a problem hiding this comment.
@colemanw yes because on 'Manage Group', for some group, I am getting group-contact's count > 25, reason why I haven't added limit = 0 option.
There was a problem hiding this comment.
I found that for 'getcount' API action, the limit is not used here
colemanw
approved these changes
Jun 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.