Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-20643 Fix invalid bounce type filter for bounce report #10427

Merged
merged 1 commit into from
Aug 9, 2017

Conversation

mattwire
Copy link
Contributor

When building the options for bounce type filter an invalid option is added first " – please select --". This causes the report to default to this value and not load any data.

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@totten totten added the master label Jun 27, 2017
@mattwire
Copy link
Contributor Author

mattwire commented Aug 7, 2017

@eileenmcnaughton This is a trivial one, reports is your area of expertise right :-)

@eileenmcnaughton
Copy link
Contributor

@mattwire your analysis here makes sense & given that this is a fairly safe/trivial change I feel that I can rely on the testing you have done on this one. Merging

@eileenmcnaughton eileenmcnaughton merged commit 448f462 into civicrm:master Aug 9, 2017
@mattwire mattwire deleted the report_bounce_type branch August 28, 2017 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants