Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-20611: fix financial records of cancelled line_items on event fee change selection #10390

Merged
merged 1 commit into from
Jun 16, 2017

Conversation

monishdeb
Copy link
Member

@monishdeb monishdeb commented May 22, 2017

@monishdeb
Copy link
Member Author

@pradpnayak can you please QA this PR!!

@pradpnayak
Copy link
Contributor

@monishdeb i did some qa, but i still found an entry with net_amount not set properly

Steps :

  1. Added participant to Fall Fundraiser Dinner Event by selecting option 'Family - $ 200.00' (trxn id 1 & 2 from image)
  2. I did change selection from 'Family - $ 200.00' to Couple - $ 100.00(trxn id 3) -- still not fixed
  3. Recorded refund (trxn id 4)

Before Patch db entries
screenshot2

After Patch db entries
screenshot1

@monishdeb
Copy link
Member Author

@pradpnayak thanks for your feedback. I have updated PR with the fix. Please have a look!

@pradpnayak
Copy link
Contributor

QA'd, working fine
scree

@JoeMurray JoeMurray changed the title CRM-20611: fix financial records of cancelled line-items on event fee change selection CRM-20611: fix financial records of cancelled line_items on event fee change selection May 26, 2017
@colemanw
Copy link
Member

Looks like a clean bugfix. It includes a test and has been manually tested as well. Merging.

@colemanw colemanw merged commit 9d1b2a8 into civicrm:master Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants