Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-20516: Card type widget appears on front end when a different processor selected #10375

Merged
merged 1 commit into from
May 19, 2017
Merged

CRM-20516: Card type widget appears on front end when a different processor selected #10375

merged 1 commit into from
May 19, 2017

Conversation

monishdeb
Copy link
Member

@monishdeb monishdeb commented May 18, 2017 •
edited by civicrm-builder
Loading

@monishdeb
Copy link
Member Author

This has resolved the issue not only on online contribution page but also in Contribution backoffice pop-up form
image

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@monishdeb
Copy link
Member Author

Jenkin, test this please

jitendrapurohit
jitendrapurohit approved these changes May 19, 2017
View reviewed changes
Copy link
Contributor

@jitendrapurohit jitendrapurohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that it works correctly on drupal 7 for backoffice and live Contribution, Membership and Event pages.

@seamuslee001 Can you please confirm if this change doesn't harm your requirements fixed in e73ea57 for Drupal 8? Thanks.

@seamuslee001
Copy link
Contributor

Tested it as well on a D8 build and looks fine to me thanks for checking @jitendrapurohit @monishdeb

@monishdeb
Copy link
Member Author

Thanks, @seamuslee001 @jitendrapurohit for your feedback. Merging it now

@monishdeb monishdeb merged commit c88b7db into civicrm:master May 19, 2017
@monishdeb monishdeb deleted the CRM-20516 branch May 19, 2017 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jitendrapurohit jitendrapurohit jitendrapurohit approved these changes

Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@monishdeb @seamuslee001 @jitendrapurohit @civicrm-builder