CRM-20594: Optimize Counting of Reltionships on Contact Summary #10371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contacts with a lot of relationships (over 5000) were taking a lot of time to load. This was because the count of relationships was being done by fetching ALL records of relationships associated to the contact, and then counting the number of elements in the resulting array. Fixed by changing the call to CRM_Contact_BAO_Relationship::getRelationship() being used in CRM_Contact_BAO_Contact::getCountComponent(), passing the $count parameter as 1 instead of 0, so counting is done by the database by building a 'SELECT COUNT(*)' type of query. Also, removed some unnecessary joins when counting records in DB, ie. when $count flag is 1.
colemanw
approved these changes
May 17, 2017
|
Jenkins re test this please |
2 similar comments
|
Jenkins re test this please |
|
Jenkins re test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contacts with a lot of relationships (over 5000) were taking a lot of time to load. This was because the count of relationships was being done by fetching ALL records of relationships associated to the contact, and then counting the number of elements in the resulting array.
Fixed by changing the call to CRM_Contact_BAO_Relationship::getRelationship() being used in CRM_Contact_BAO_Contact::getCountComponent(), passing the $count parameter as 1 instead of 0, so counting is done by the database by building a 'SELECT COUNT(*)' type of query.
Also, removed some unnecessary joins when counting records in DB, by embedding them in an if statement, entered when $count flag is different to 1.