Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-20585 -Correct the from and to accounts for deferred revenue transactions #10367

Merged
merged 3 commits into from
May 22, 2017
Merged

CRM-20585 -Correct the from and to accounts for deferred revenue transactions #10367

merged 3 commits into from
May 22, 2017

Conversation

pradpnayak
Copy link
Contributor

@pradpnayak pradpnayak commented May 17, 2017 •
edited by civicrm-builder
Loading

@pradpnayak pradpnayak changed the title Crm 20585 CRM-20585 -Correct the from and to accounts for deferred revenue transactions May 17, 2017
pradpnayak added 3 commits May 21, 2017 00:14
@pradpnayak
CRM-20585, Added unit test to check to and from entries in financial …
7b5169d 
…trxn table for deferred revenue

----------------------------------------
* CRM-20585: Correct the from and to accounts for deferred revenue transactions
  https://issues.civicrm.org/jira/browse/CRM-20585
@pradpnayak
--CRM-20585, fixed financial trxn entry for deferred revenue
f818aed 
CRM-20585, fixed jenkins style

----------------------------------------
* CRM-20585: Correct the from and to accounts for deferred revenue transactions
  https://issues.civicrm.org/jira/browse/CRM-20585
@pradpnayak
CRM-20585, changed query since to financial accoun holds deferred rev…
bb40e74 
…enue now

----------------------------------------
* CRM-20585: Correct the from and to accounts for deferred revenue transactions
  https://issues.civicrm.org/jira/browse/CRM-20585
@pradpnayak
Copy link
Contributor Author

@monishdeb could please review and QA this PR?

monishdeb
monishdeb approved these changes May 22, 2017
View reviewed changes
Copy link
Member

@monishdeb monishdeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the patch. Fixes the problem as now 'Deferred Revenue' account correctly sets at to_financial_account_id instead of from_financial_account_id. The added unit test covers the fix well.

@monishdeb
Copy link
Member

@colemanw can you please merge this PR!

@colemanw colemanw merged commit cdc6de7 into civicrm:master May 22, 2017
@pradpnayak pradpnayak deleted the CRM-20585 branch May 29, 2017 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monishdeb monishdeb monishdeb approved these changes

Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pradpnayak @monishdeb @colemanw @civicrm-builder