CRM-20590, add pre and post hook invocation for delete and create/edi… #10366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins re test this please |
1 similar comment
|
Jenkins re test this please |
|
I think we should put a create function into CRM_Batch_BAO_EntityBatch and put these hooks (& functions) in there. This is currently a bit of an inconsistent construct, & trying to add hooks to it highlights that |
|
Makes sense. I will update the changes soon. |
…t option ---------------------------------------- * CRM-20590: Add pre and post hook for EntityBatch https://issues.civicrm.org/jira/browse/CRM-20590
---------------------------------------- * CRM-20590: Add pre and post hook for EntityBatch https://issues.civicrm.org/jira/browse/CRM-20590
|
@eileenmcnaughton I have pushed the changes suggested by you. Can you please review? |
---------------------------------------- * CRM-20590: Add pre and post hook for EntityBatch https://issues.civicrm.org/jira/browse/CRM-20590
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t option
https://issues.civicrm.org/jira/browse/CRM-20590