CRM-20562: Duplicate Activities created during participant registration v… #10362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ia completetransaction
720becc to
71acd4b
Compare
| @@ -2107,6 +2107,7 @@ public static function addActivity( | |||
| $id = CRM_Core_Session::getLoggedInContactID(); | |||
| if ($id) { | |||
| $activityParams['source_contact_id'] = $id; | |||
| $activityParams['target_contact_id'][] = $activity->contact_id; | |||
There was a problem hiding this comment.
Can you explain the logic here? I worry there might be cases where it is not populated..
There was a problem hiding this comment.
This is required when registering an additional participant and activity gets created for only primary contact. As we get the logged in contact id we replace the source_contact with it.
Keeping the $activity->contact_id in target would show the activities for additional participant too.
shall I check for !empty($activity->contact_id) in case this might not populate but I see this has been already assigned to source_contact which is being replaced here, so it should always be there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ia completetransaction.
As all required activities already gets created above while calling participant create api, writing addActivity() again would be an additional creation on them. Removing this call as I don't find any use-case where these lines might be required.
https://issues.civicrm.org/jira/browse/CRM-20562