CRM-20532 Fix issue where cannot get information on a single extensio… #10322
Conversation
…n with extension.get api and ensure that Fields specified in return key are supported
|
ping @eileenmcnaughton @twomice @ineffyble I think this fixes it in an elegant way whilst still supporting that effort to have all information for Extensions returned |
| /** | ||
| * Test retunging a single extension | ||
| */ | ||
| public function testSingleExtesnionGet() { |
api/v3/Extension.php
Outdated
| @@ -332,6 +332,7 @@ function _civicrm_api3_extension_refresh_spec(&$fields) { | |||
| * API result | |||
| */ | |||
| function civicrm_api3_extension_get($params) { | |||
| $keys = (array) $params['key']; | |||
There was a problem hiding this comment.
could this cause an enotice?
There was a problem hiding this comment.
I think you can cast a null as an array
There was a problem hiding this comment.
would it never not be set?
api/v3/Extension.php
Outdated
| } | ||
| return _civicrm_api3_basic_array_get('Extension', $params, $result, 'id', array()); | ||
| $returnFields = !empty($params['return']) ? (array) $params['return'] : array(); |
There was a problem hiding this comment.
I think you should use $options = _civicrm_api3_get_options_from_params() to extract return - we do support 'return' as an array or comma separated string & should be consistent in our inconsistency
| @@ -346,9 +347,17 @@ function civicrm_api3_extension_get($params) { | |||
| } | |||
| $info = CRM_Extension_System::createExtendedInfo($obj); | |||
| $info['id'] = $id++; // backward compatibility with indexing scheme | |||
| $result[] = $info; | |||
| if (!empty($params['key'])) { | |||
There was a problem hiding this comment.
what about moving the filtering to the start of the loop - I have a feeling some of those calls are expensive
There was a problem hiding this comment.
I tried that and didn't seem to get anywhere
There was a problem hiding this comment.
Also doing it further down keeps the indexing the same no matter what the get is like
There was a problem hiding this comment.
ok - is this not slow? $info = CRM_Extension_System::createExtendedInfo($obj);
There was a problem hiding this comment.
Doesn't feel that slow to me
|
Makes sense - if the tests can't find anything wrong then I can't either |
…arams and adding an isset test to the ['key']
|
@eileenmcnaughton ought the jira ticket https://issues.civicrm.org/jira/browse/CRM-20532 be closed as well? |
|
@colemanw I'm dealing with JIRA and I think I'll put a note on the API change log |
…n with extension.get api and ensure that Fields specified in return key are supported