Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-20510: Petition signature doesn't show as an activity type for scheduled reminder #10301

Merged
merged 1 commit into from
May 9, 2017

Conversation

monishdeb
Copy link
Member

@monishdeb monishdeb commented May 4, 2017

@monishdeb
Copy link
Member Author

Petition Signature activity type is now available in SR form
image

@pradpnayak
Copy link
Contributor

QA'd
Petition and other Activity type for Campaign are visible now in drop down list.

@seamuslee001
Copy link
Contributor

Jenkins test this please

@seamuslee001
Copy link
Contributor

@monishdeb can you fix the style issue? whitespace end of line 289

@monishdeb
Copy link
Member Author

Thanks @seamuslee001 , updated the PR

@eileenmcnaughton
Copy link
Contributor

Merging. @pradpnayak has confirmed this fixes the issue & it makes sense and is a safe patch IMHO

I think that using buildOptions would have had the same effect and in general we are trying to move things that way, but not going to hold this up on that.

@eileenmcnaughton eileenmcnaughton merged commit f67d2fb into civicrm:master May 9, 2017
@monishdeb monishdeb deleted the CRM-20510 branch May 10, 2017 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants