Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-20513 Fix recur status update & et next recur date based on payme… #10294

Merged
merged 1 commit into from
May 4, 2017

Conversation

eileenmcnaughton
Copy link
Contributor

…nt date not current date.

The code to set a recurring sequence to Completed when all contributions received turned out
to be flawed. This fixes that.

This commit extends the test on how dates are being extended. I didn't replicate the problem
I was expecting to see but it makes sense that recurring transactions could be imported on
a different day to the current one and that date is the important one

…nt date not current date.

The code to set a recurring sequence to Completed when all contributions received turned out
to be flawed. This fixes that.

This commit extends the test on how dates are being extended. I didn't replicate the problem
I was expecting to see but it makes sense that recurring transactions could be imported on
a different day to the current one and that date is the important one
Copy link
Member

@monishdeb monishdeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working fine. Test cases are straightforward to handle defined receieve_date and set the next_sched_contribution_date accordingly

@monishdeb monishdeb merged commit de840a0 into civicrm:master May 4, 2017
@eileenmcnaughton eileenmcnaughton deleted the recur branch May 4, 2017 05:36
@eileenmcnaughton
Copy link
Contributor Author

Thanks @monishdeb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants