Fixes to activity display in case timeline #10281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ang/crmCaseType.js
Outdated
| @@ -391,5 +397,6 @@ | |||
| }); | |||
| }; | |||
| }); | |||
| // console.log($scope.) | |||
|
@colemanw one for you to review? |
|
also noticed that "Newest" and "Oldest" were never translated |
|
@agh1 Andrew test failures look legit |
|
@seamuslee001 thanks--the test was missing the activity type data for two of the activity types it used. (My changes look up the activity type to find the label.) |
|
Code looks good, tested it out and was able to reproduce the bug & confirm that this fixes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues when editing a case timeline: