CRM-20171: Use loadXML() instead of load() for reading xml files. #10264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9b29930 to
6498e0d
Compare
|
test fails are real :-( |
|
When using loadXML(), the documentURI property is set to base directory instead of current file path which is why the xinclude() fails as the parser will not know where to find the files to include. More about this - http://php.net/manual/en/domdocument.xinclude.php#76372. I've updated the PR with the fix, should pass the build now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid warnings while loading xml files. To make sure security of XXE attacks, restored the previous value at each modification in the file.