CRM-20424 remove call to deprecated function.

[eileenmcnaughton]

This is the one covering the UI with errors. The fact it did not cause any test fails means it is
not covered by unit tests :-(.

As long as the Open Case link is still present for CiviCase users this is working

@davejenx might be worth merging this into the rc? Will clean up the most common source of red ink

---

• CRM-20424: Set up method for marking code as deprecated

[davejenx]

@eileenmcnaughton This PR gets rid of the warning on most Civi pages. :-) Which link does this code provide?
There's still a warning on CiviCase Dashboard:
User deprecated function: Deprecated function, use CRM_Core_PseudoConstant::getKey Array ( [civi.tag] => deprecated ) in CRM_Core_Error_Log->log() (line 69 of /Users/davej/src/buildkit/build/dmaster/sites/all/modules/civicrm/CRM/Core/Error/Log.php).
I see there are different URLs in use for create case links:

• /civicrm/case/add?reset=1&action=add&atype=13&context=standalone
  used for New Case menu item under Cases menu
• /civicrm/case/add?reset=1&action=add&context=case&cid=132
  used for Add Case from Actions menu button on contact summary
• /civicrm/case/add?action=add&context=standalone&reset=1
  used for Add Case button on CiviCase Dashboard

Which suggests the activity type may not be needed anyway!

[eileenmcnaughton]

It seems to provide
'ref' => 'new-case',
'title' => ts('Case'),

reset=1&action=add&atype={$activityType}&context=standalone

which is none of those!

[eileenmcnaughton]

hmm maybe it is - the activity type is 'Open Case' - does that co-incide with atype=13?

Required params
if (CRM_Core_Permission::check('access all cases and activities') ||
CRM_Core_Permission::check('add cases')

[eileenmcnaughton]

AHA! that's where it is

[eileenmcnaughton]

& it was wrong! just fixed it - but also fixed one more that filters out 'Closed' cases when looking at 'upcoming' cases on the case dashboard

[seamuslee001]

looks fine to me