CRM16421 CRM 17633: Changes to support WP in it's own directory. Allo… #10214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w for civicrn.settings.extra.php for WP. Create template for civicrm.settings.extra.php. Update install/civicrm.php for all needed params for different common install scenarios. Fix linting issues in civicrm.php. CRM 16421 CRM 17633 - update CRM_Utils_System_WordPress to allow for common install configurations
|
Please see details on #9106 |
|
This requires civicrm/civicrm-wordpress#105 |
Following up on the discussion from [civicrm#10513](civicrm#10513), this converts the proposed constants `CIVICRM_UF_WP_BASEURL` and `CIVICRM_UF_ADMINURL` to variables in the `Paths` system. A few benefits: * Reduces code duplication between `civicrm.php` and `WordPress.php`. * Can construct sub-paths with prettier notation (`Civi::paths()->getUrl('[wp.frontend]/foo.txt')`) * Has options to output relative or absolute URLs * Can expand on `Paths` to provide more inspection/validation Notes: * `CIVICRM_UF_WP_BASEURL` => `wp.frontend.base` * `CIVICRM_UF_ADMINURL` => `wp.backend.base` ---------------------------------------- * CRM-16421: Work to get CiviCRM for WordPress in WordPress' official Repository https://issues.civicrm.org/jira/browse/CRM-16421
…tings.php` ---------------------------------------- * CRM-16421: Work to get CiviCRM for WordPress in WordPress' official Repository https://issues.civicrm.org/jira/browse/CRM-16421
CRM-16421 - Convert constants to `$civicrm_paths`
|
@totten tested and merged your improvements. Works fine. Would like this in early in an RC cycle to get more eyes/hands on the rela world testing. |
|
@totten test failure appears unrelated. Can you confirm? |
|
test this please |
|
test this please |
|
@totten @kcristiano this appears to have been worked on and broadly agreed. Can you reconfirm & we could plan to merge at the end of the week? |
|
@eileenmcnaughton I can confirm that this is ready for merge (in my opinion). There is the related patch for the wordpress repo - civicrm/civicrm-wordpress#105 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…w for civicrn.settings.extra.php for WP. Create template for civicrm.settings.extra.php. Update install/civicrm.php for all needed params for different common install scenarios. Fix linting issues in civicrm.php.
CRM 16421 CRM 17633 - update CRM_Utils_System_WordPress to allow for common install configurations
Replaces #9106