New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-20435: Replace SQL-based activityContact creation with DAO-based approach. #10168

Merged

eileenmcnaughton merged 1 commit into civicrm:master from universalhandle:CRM-20435

Apr 23, 2017

Contributor

universalhandle commented Apr 15, 2017 •

edited by civicrm-builder

Loading

CRM-20435: Don't use SQL in CRM_Activity_BAO_Activity::create() where DAO will suffice


          CRM-20435: Conservative replacement of SQL-based activityContact crea…

a857867

…tion with DAO-based approach.

civicrm-builder added the master label

Contributor

eileenmcnaughton commented Apr 23, 2017

I'm going to merge this as

code looks good & solves the described problem
I feel comfortable there is good test coverage over this
the performance feels negligible here as it could only apply to one activity. I do realise some (bulk mail) might have a lot of targets - but it seems doubtful that is a huge issue & OTOH we should find a 'real' way to deal with bulk operations which integrates with hooks if that is a thing

eileenmcnaughton merged commit 0710631 into civicrm:master

universalhandle deleted the CRM-20435 branch

April 24, 2017 22:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels