Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-9683 implement timezone support for CiviMail. #10154

Merged
merged 2 commits into from
Apr 23, 2017
Merged

CRM-9683 implement timezone support for CiviMail. #10154

merged 2 commits into from
Apr 23, 2017

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 13, 2017 •
edited by civicrm-builder
Loading

@jmcclelland - this is an implementation of your proposal to change the field type to timestamp for new installs for mailing date fields - I added the others than seemed clear-cut. Easiest to read here
24ea26b

@eileenmcnaughton eileenmcnaughton force-pushed the timestamp branch 2 times, most recently from cda13c4 to e2951c9 Compare April 13, 2017 07:28
@eileenmcnaughton
Copy link
Contributor Author

Hmm - I think all created_date fields should have CURRENT_TIMESTAMP - looks like it's important to set required=false & default=null or else it gets set to one of these

added_at timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP COMMENT 'date on which this job was added.',
removed_at timestamp NOT NULL DEFAULT '0000-00-00 00:00:00' COMMENT 'date on which this job was removed.',

@jmcclelland
Copy link
Contributor

Thanks Eileen - this is great!

@seamuslee001
Copy link
Contributor

@eileenmcnaughton i have rebased this for you

@eileenmcnaughton
CRM-9683 implement timezone support for CiviMail
4387c66 
This will affect new installs only per discussion on the ticket. Motivation dependent, we could add a method to convert on existing installs.

Note some fields, like event_start_date might have a case for being in a non-timezone aware format
@eileenmcnaughton
CRM-9683 regenerate DAOs
6c2b97b
@eileenmcnaughton eileenmcnaughton merged commit 83ac183 into civicrm:master Apr 23, 2017
@eileenmcnaughton eileenmcnaughton deleted the timestamp branch April 23, 2017 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eileenmcnaughton @jmcclelland @seamuslee001 @civicrm-builder