CRM-20367 - Allow addIndex $column to be an array #10131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
colemanw
commented
Apr 8, 2017
•
- CRM-20367: Add wrapper function for adding and dropping Index in Upgrader
|
@monishdeb I saw that the underlying function allows the param to be an array, so I thought "why not?" |
|
@colemanw yes agree. I realized the same when I was going to add unique index for a table, so made that changes in my PR itself https://github.com/civicrm/civicrm-core/pull/10056/files#diff-a520f3c157b280eab92fcf3e1afb390aR176. But I agree we need to separate that fix out under CRM-20367 PR. I will bring changes in my PR accordingly after it gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.