Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-15067 use email addresses in profile if present #10079

Closed
wants to merge 2 commits into from

Conversation

lcdservices
Copy link
Contributor

@lcdservices lcdservices commented Mar 29, 2017

@kcristiano
Copy link
Member

@lcdservices Rebased patch on current master.

Tested Patch with a profile with an email field. Email field appears in the profile.
Tested with profile without email address. Email field is above the profiles.
Tested with two profiles. First has No email field , second has an email field. Email appears in second profile
Tested with no profiles. Email field appears.

Rebased #10349

@colemanw colemanw closed this May 13, 2017
@petednz
Copy link

petednz commented Jul 9, 2017

Has this had any role in breaking the feature of 'create user' in a Profile? See https://issues.civicrm.org/jira/browse/CRM-20834

@kcristiano
Copy link
Member

@petednz Very possible that it is related. I did test user creation back in May for both WP and Drupal. At the time it worked. Testing again on WP with 4.7.21 user creation is working. For Drupal I can confirm that it fails. i am not as familiar with Drupal so I do think it possible that this PR could be to blame.

@xurizaemon
Copy link
Member

xurizaemon commented Jul 10, 2017

Yep, on an affected site if we back out the changes in this block of 8803e32, contributions resume working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants