CRM-19385 - remove dependence on ids in cache tables. #10019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the use of the primary id keys in the cache tables. The upgrade part of this has gone stale a few times but I feel sure that this part is tested & confirmed and committing this part will make testing easier
|
This is the non-db change portion of #9801 - the PR keeps going stale & I think these changes, & additional test are not dependent on the Db changes so I am putting them in a separate PR |
|
this is a distillation of the changes from #9801 that I feel able to approve for merge at this stage |
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Mar 29, 2017
After PR civicrm#10019 was merged @bhahumanists reported on civicrm#9801 that smart group ordering was broken. The report is lacking detail and I could not replicate it, but am reverting the search changes for safety. After this revert sites can still experiment with dropping/altering the primary key on -civicrm_cache -civicrm_group_contact_cache -civicrm_acl_cache But not civicrm_prevnext_cache. Although I could not replicate the search issue it seems to me that our Ubuntu test suite is failing where the other one is not on search-related items, suggesting that for some reason Ubuntu does not default to the natural search order, due to some config or other difference
eileenmcnaughton
added a commit
that referenced
this pull request
Mar 29, 2017
* Minor test tidy up. (this is actually because we need a commit to do a merge to master after the same commit was merged to both). * CRM-20342: add 'view' Api action * CRM-19385 revert changes to order by id on prevnext_cache. After PR #10019 was merged @bhahumanists reported on #9801 that smart group ordering was broken. The report is lacking detail and I could not replicate it, but am reverting the search changes for safety. After this revert sites can still experiment with dropping/altering the primary key on -civicrm_cache -civicrm_group_contact_cache -civicrm_acl_cache But not civicrm_prevnext_cache. Although I could not replicate the search issue it seems to me that our Ubuntu test suite is failing where the other one is not on search-related items, suggesting that for some reason Ubuntu does not default to the natural search order, due to some config or other difference
monishdeb
pushed a commit
to monishdeb/civicrm-core
that referenced
this pull request
May 2, 2017
CRM-19385 - remove dependence on ids in cache tables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the use of the primary id keys in the cache tables. The upgrade part of this
has gone stale a few times but I feel sure that this part is tested & confirmed
and committing this part will make testing easier