drupal 9 views fix (alternative)

I took a look at #20682 and it seemed clear that
in it's current state it would fix one CMS (d9) & break another (d7). This is
an alternate that will hopefully be non-breaky

CRM/Admin/Form/Setting/UF.php

@@ -67,8 +67,8 @@ public function buildQuickForm() {
         $config->dsn != $config->userFrameworkDSN || !empty($drupal_prefix)
       )
     ) {
-      $dsn = CRM_Utils_SQL::autoSwitchDSN($config->dsn);
-      $dsnArray = DB::parseDSN($dsn);
+
+      $dsnArray = DB::parseDSN(CRM_Utils_SQL::autoSwitchDSN($config->dsn));
       $tableNames = CRM_Core_DAO::getTableNames();
       asort($tableNames);
       $tablePrefixes = '$databases[\'default\'][\'default\'][\'prefix\']= [';
@@ -77,13 +77,7 @@ public function buildQuickForm() {
       }
       // add default prefix: the drupal database prefix
       $tablePrefixes .= "\n  'default' => '$drupal_prefix',";
-      $prefix = "";
-      if ($config->dsn != $config->userFrameworkDSN) {
-        $prefix = "`{$dsnArray['database']}`.";
-        if ($config->userFramework === 'Backdrop') {
-          $prefix = "{$dsnArray['database']}.";
-        }
-      }
+      $prefix = $config->userSystem->getCMSDatabasePrefix();
       foreach ($tableNames as $tableName) {
         $tablePrefixes .= "\n  '" . str_pad($tableName . "'", 41) . " => '{$prefix}',";
       }

CRM/Utils/System/Backdrop.php

@@ -1056,4 +1056,16 @@ public function getCMSPermissionsUrlParams() {
     return ['ufAccessURL' => url('admin/config/people/permissions')];
   }
 
+  /**
+   * Get the CMS database as a 'prefix'.
+   *
+   * This returns a string that can be prepended to a query to include a CMS table.
+   *
+   * However, this string should contain backticks, or not, in accordance with the
+   * CMS's drupal views expectations, if any.
+   */
+  public function getCMSDatabasePrefix(): string {
+    return str_replace(parent::getCMSDatabasePrefix(), '`', '');
+  }
+
 }

CRM/Utils/System/Base.php

@@ -1051,6 +1051,23 @@ public function getCMSPermissionsUrlParams() {
     return [];
   }
 
+  /**
+   * Get the CMS database as a 'prefix'.
+   *
+   * This returns a string that can be prepended to a query to include a CMS table.
+   *
+   * However, this string should contain backticks, or not, in accordance with the
+   * CMS's drupal views expectations, if any.
+   */
+  public function getCMSDatabasePrefix(): string {
+    $crmDatabase = DB::parseDSN(CRM_Core_Config::singleton()->dsn)['database'];
+    $cmsDatabase = DB::parseDSN(CRM_Core_Config::singleton()->dsn)['database'];
+    if ($crmDatabase === $cmsDatabase) {
+      return '';
+    }
+    return "`$cmsDatabase`.";
+  }
+
   /**
    * Invalidates the cache of dynamic routes and forces a rebuild.
    */

CRM/Utils/System/Drupal9.php

@@ -0,0 +1,21 @@
+<?php
+/*
+ +--------------------------------------------------------------------+
+ | Copyright CiviCRM LLC. All rights reserved.                        |
+ |                                                                    |
+ | This work is published under the GNU AGPLv3 license with some      |
+ | permitted exceptions and without any warranty. For full license    |
+ | and copyright information, see https://civicrm.org/licensing       |
+ +--------------------------------------------------------------------+
+ */
+
+/**
+ *
+ * @package CRM
+ * @copyright CiviCRM LLC https://civicrm.org/licensing
+ */
+
+/**
+ * Drupal specific stuff goes here.
+ */
+class CRM_Utils_System_Drupal9 extends CRM_Utils_System_Drupal8 {}