[NFC] {test} minor cleanup

civicrm · May 24, 2021 · f012e08 · f012e08
1 parent 94178a8
commit f012e08
Show file tree

Hide file tree

Showing 2 changed files with 204 additions and 163 deletions.
diff --git a/tests/phpunit/CiviTest/CiviUnitTestCase.php b/tests/phpunit/CiviTest/CiviUnitTestCase.php
@@ -3595,7 +3595,7 @@ protected function getParticipantOrderParams(): array {
    *
    * @throws \CRM_Core_Exception
    */
-  protected function validatePayments($payments) {
+  protected function validatePayments($payments): void {
     foreach ($payments as $payment) {
       $balance = CRM_Contribute_BAO_Contribution::getContributionBalance($payment['contribution_id']);
       if ($balance < 0 && $balance + $payment['total_amount'] === 0.0) {
@@ -3632,7 +3632,7 @@ protected function validateAllPayments() {
    *
    * @throws \CRM_Core_Exception
    */
-  protected function validateAllContributions() {
+  protected function validateAllContributions(): void {
     $contributions = $this->callAPISuccess('Contribution', 'get', ['return' => ['tax_amount', 'total_amount']])['values'];
     foreach ($contributions as $contribution) {
       $lineItems = $this->callAPISuccess('LineItem', 'get', ['contribution_id' => $contribution['id']])['values'];