Merge pull request #20144 from eileenmcnaughton/never

hook_managed - do not try to disable managed entities if is_active is not available to api3.create
civicrm · May 7, 2021 · c96bdd5 · c96bdd5
2 parents 638fdb5 + 3cf0255
commit c96bdd5
Showing 1 changed file with 28 additions and 4 deletions.
diff --git a/CRM/Core/ManagedEntities.php b/CRM/Core/ManagedEntities.php
@@ -264,7 +264,10 @@ public function updateExistingEntity($dao, $todo) {
     $doUpdate = ($policy == 'always');
 
     if ($doUpdate) {
-      $defaults = ['id' => $dao->entity_id, 'is_active' => 1];
+      $defaults = ['id' => $dao->entity_id];
+      if ($this->isActivationSupported($dao->entity_type)) {
+        $defaults['is_active'] = 1;
+      }
       $params = array_merge($defaults, $todo['params']);
 
       $manager = CRM_Extension_System::singleton()->getManager();
@@ -301,10 +304,12 @@ public function updateExistingEntity($dao, $todo) {
    * inactive.
    *
    * @param CRM_Core_DAO_Managed $dao
+   *
+   * @throws \CiviCRM_API3_Exception
    */
-  public function disableEntity($dao) {
-    // FIXME: if ($dao->entity_type supports is_active) {
-    if (TRUE) {
+  public function disableEntity($dao): void {
+    $entity_type = $dao->entity_type;
+    if ($this->isActivationSupported($entity_type)) {
       // FIXME cascading for payproc types?
       $params = [
         'version' => 3,
@@ -479,4 +484,23 @@ protected function onApiError($entity, $action, $params, $result) {
     throw new Exception('API error: ' . $result['error_message'] . ' on ' . $entity . '.' . $action);
   }
 
+  /**
+   * Determine if an entity supports APIv3-based activation/de-activation.
+   * @param string $entity_type
+   *
+   * @return bool
+   * @throws \CiviCRM_API3_Exception
+   */
+  private function isActivationSupported(string $entity_type): bool {
+    if (!isset(Civi::$statics[__CLASS__][__FUNCTION__][$entity_type])) {
+      $actions = civicrm_api3($entity_type, 'getactions', [])['values'];
+      Civi::$statics[__CLASS__][__FUNCTION__][$entity_type] = FALSE;
+      if (in_array('create', $actions, TRUE) && in_array('getfields', $actions)) {
+        $fields = civicrm_api3($entity_type, 'getfields', ['action' => 'create'])['values'];
+        Civi::$statics[__CLASS__][__FUNCTION__][$entity_type] = array_key_exists('is_active', $fields);
+      }
+    }
+    return Civi::$statics[__CLASS__][__FUNCTION__][$entity_type];
+  }
+
 }