Refactor entityParams in Order.Create API so it is easier to understa…

…nd/modify
civicrm · Oct 19, 2020 · bd94f95 · bd94f95
1 parent 776662b
commit bd94f95
Showing 1 changed file with 20 additions and 11 deletions.
diff --git a/api/v3/Order.php b/api/v3/Order.php
@@ -88,21 +88,30 @@ function civicrm_api3_order_create($params) {
         $item = reset($lineItems['line_item']);
         $entity = str_replace('civicrm_', '', $item['entity_table']);
       }
+
       if ($entityParams) {
-        if (in_array($entity, ['participant', 'membership'])) {
-          $entityParams['skipLineItem'] = TRUE;
-          $entityParams['status_id'] = ($entity === 'participant' ? 'Pending from incomplete transaction' : 'Pending');
-          $entityResult = civicrm_api3($entity, 'create', $entityParams);
-          $params['contribution_mode'] = $entity;
-          $entityIds[] = $params[$entity . '_id'] = $entityResult['id'];
-          foreach ($lineItems['line_item'] as &$items) {
-            $items['entity_id'] = $entityResult['id'];
-          }
+        switch ($entity) {
+          case 'participant':
+            $entityParams['status_id'] = 'Pending from incomplete transaction';
+            break;
+
+          case 'membership':
+            $entityParams['status_id'] = 'Pending';
+            break;
+
+          default:
+            // Don't create any related entities. We might want to support eg. Pledge one day?
+            break 2;
         }
-        else {
-          // pledge payment
+        $entityParams['skipLineItem'] = TRUE;
+        $entityResult = civicrm_api3($entity, 'create', $entityParams);
+        $params['contribution_mode'] = $entity;
+        $entityIds[] = $params[$entity . '_id'] = $entityResult['id'];
+        foreach ($lineItems['line_item'] as &$items) {
+          $items['entity_id'] = $entityResult['id'];
         }
       }
+
       if (empty($priceSetID)) {
         $item = reset($lineItems['line_item']);
         $priceSetID = (int) civicrm_api3('PriceField', 'getvalue', [