Issue#521: Send notification after successful contribution payment

civicrm · Mar 19, 2021 · b6038fc · b6038fc
1 parent e4e20a1
commit b6038fc
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/CRM/Contribute/BAO/Contribution.php b/CRM/Contribute/BAO/Contribution.php
@@ -4259,6 +4259,19 @@ public static function completeOrder($input, $ids, $contribution, $isPostPayment
 
     $transaction->commit();
     \Civi::log()->info("Contribution {$contributionParams['id']} updated successfully");
+    $contributionSoft = civicrm_api4('ContributionSoft', 'get', [
+      'where' => [
+        ['contribution_id', '=', $contributionID],
+      ],
+      'checkPermissions' => FALSE,
+    ]);
+
+    if (!empty($contributionSoft)) {
+      //Send notification to owner for PCP
+      if ($contributionSoft->column('pcp_id')) {
+        CRM_Contribute_Form_Contribution_Confirm::pcpNotifyOwner($contribution, $contributionSoft[0]);
+      }
+    }
 
     // @todo - check if Contribution::create does this, test, remove.
     CRM_Contribute_BAO_ContributionRecur::updateRecurLinkedPledge($contributionID, $recurringContributionID,

diff --git a/CRM/Contribute/BAO/ContributionSoft.php b/CRM/Contribute/BAO/ContributionSoft.php
@@ -607,10 +607,6 @@ protected static function processPCP($pcp, $contribution) {
       $softParams['pcp_personal_note'] = $pcp['pcp_personal_note'] ?? NULL;
       $softParams['soft_credit_type_id'] = CRM_Core_PseudoConstant::getKey('CRM_Contribute_BAO_ContributionSoft', 'soft_credit_type_id', 'pcp');
       $contributionSoft = self::add($softParams);
-      //Send notification to owner for PCP
-      if ($contributionSoft->pcp_id && empty($pcpId)) {
-        CRM_Contribute_Form_Contribution_Confirm::pcpNotifyOwner($contribution, (array) $contributionSoft);
-      }
     }
     //Delete PCP against this contribution and create new on submitted PCP information
     elseif ($pcpId) {

diff --git a/CRM/Contribute/Form/Contribution/Confirm.php b/CRM/Contribute/Form/Contribution/Confirm.php
@@ -1225,7 +1225,7 @@ public static function processOnBehalfOrganization(&$behalfOrganization, &$conta
    *
    * @param object $contribution
    * @param array $contributionSoft
-   *   Contribution object.
+   *   Contribution array.
    *
    * @throws \API_Exception
    * @throws \CRM_Core_Exception