Merge pull request #24442 from eileenmcnaughton/depp

Increase the deprecation on some unused functions
civicrm · Sep 3, 2022 · 96e0523 · 96e0523
2 parents 97e2ee3 + a475644
commit 96e0523
Showing 1 changed file with 7 additions and 28 deletions.
diff --git a/CRM/Import/Parser.php b/CRM/Import/Parser.php
@@ -240,13 +240,6 @@ public function getContactSubType(): ?string {
    */
   protected $_invalidRowCount;
 
-  /**
-   * Maximum number of non-empty/comment lines to process
-   *
-   * @var int
-   */
-  protected $_maxLinesToProcess;
-
   /**
    * Array of error lines, bounded by MAX_ERROR
    * @var array
@@ -437,20 +430,6 @@ protected function isFillDuplicates(): bool {
    */
   protected $_rows;
 
-  /**
-   * Filename of error data
-   *
-   * @var string
-   */
-  protected $_errorFileName;
-
-  /**
-   * Filename of duplicate data
-   *
-   * @var string
-   */
-  protected $_duplicateFileName;
-
   /**
    * Contact type
    *
@@ -485,13 +464,6 @@ public function setContactSubType(?int $contactSubType): self {
     return $this;
   }
 
-  /**
-   * Class constructor.
-   */
-  public function __construct() {
-    $this->_maxLinesToProcess = 0;
-  }
-
   /**
    * Add progress bar to the import process. Calculates time remaining, status etc.
    *
@@ -506,9 +478,12 @@ public function __construct() {
    * @param $totalRowCount
    *   Total number of rows in the import file.
    *
+   * @deprecated
+   *
    * @return NULL|$currTimestamp
    */
   public function progressImport($statusID, $startImport = TRUE, $startTimestamp = NULL, $prevTimestamp = NULL, $totalRowCount = NULL) {
+    CRM_Core_Error::deprecatedFunctionWarning('no replacement');
     $statusFile = CRM_Core_Config::singleton()->uploadDir . "status_{$statusID}.txt";
 
     if ($startImport) {
@@ -585,6 +560,7 @@ public function getHeaderPatterns(): array {
    * @return void
    */
   public static function encloseScrub(&$values, $enclosure = "'") {
+    CRM_Core_Error::deprecatedFunctionWarning('no replacement');
     if (empty($values)) {
       return;
     }
@@ -604,6 +580,7 @@ public static function encloseScrub(&$values, $enclosure = "'") {
    * @return void
    */
   public function setMaxLinesToProcess($max) {
+    CRM_Core_Error::deprecatedFunctionWarning('no replacement');
     $this->_maxLinesToProcess = $max;
   }
 
@@ -774,6 +751,7 @@ private function tagImportedContactsWithNewTag(array $contactIDs, array $tags) {
    * @return string
    */
   public static function errorFileName($type) {
+    CRM_Core_Error::deprecatedFunctionWarning('no replacement');
     $fileName = NULL;
     if (empty($type)) {
       return $fileName;
@@ -1307,6 +1285,7 @@ private function _civicrm_api3_deprecated_add_formatted_param(&$values, &$params
    * @return mixed
    */
   protected function parsePseudoConstantField($submittedValue, $fieldSpec) {
+    CRM_Core_Error::deprecatedFunctionWarning('no replacement');
     // dev/core#1289 Somehow we have wound up here but the BAO has not been specified in the fieldspec so we need to check this but future us problem, for now lets just return the submittedValue
     if (!isset($fieldSpec['bao'])) {
       return $submittedValue;