Assign variable to determine whether to show email signature field

This gets us around complex 'empty checks' and allows us to avoid enotices in smarty
civicrm · Nov 25, 2021 · 91b0ba4 · 91b0ba4
1 parent 786b1f3
commit 91b0ba4
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 17 deletions.
diff --git a/CRM/Contact/Form/Edit/Email.php b/CRM/Contact/Form/Edit/Email.php
@@ -66,33 +66,32 @@ public static function buildQuickForm(&$form, $blockCount = NULL, $blockEdit = F
 
       //Bulkmail checkbox
       $form->assign('multipleBulk', $multipleBulk);
-      $js = ['id' => "Email_" . $blockId . "_IsBulkmail" , 'aria-label' => ts('Bulk Mailing for Email %1?', [1 => $blockId])];
+      $js = ['id' => 'Email_' . $blockId . '_IsBulkmail', 'aria-label' => ts('Bulk Mailing for Email %1?', [1 => $blockId])];
       if (!$blockEdit) {
         $js['onClick'] = 'singleSelect( this.id );';
       }
       $form->addElement('advcheckbox', "email[$blockId][is_bulkmail]", NULL, '', $js);
 
       //is_Primary radio
-      $js = ['id' => "Email_" . $blockId . "_IsPrimary", 'aria-label' => ts('Email %1 is primary?', [1 => $blockId])];
+      $js = ['id' => 'Email_' . $blockId . '_IsPrimary', 'aria-label' => ts('Email %1 is primary?', [1 => $blockId])];
       if (!$blockEdit) {
         $js['onClick'] = 'singleSelect( this.id );';
       }
 
       $form->addElement('radio', "email[$blockId][is_primary]", '', '', '1', $js);
-
-      if (CRM_Utils_System::getClassName($form) == 'CRM_Contact_Form_Contact') {
-        // Only display the signature fields if this contact has a CMS account
-        // because they can only send email if they have access to the CRM
-        if (!empty($form->_contactId)) {
-          $ufID = CRM_Core_BAO_UFMatch::getUFId($form->_contactId);
-          if ($ufID) {
-            $form->add('textarea', "email[$blockId][signature_text]", ts('Signature (Text)'),
-              ['rows' => 2, 'cols' => 40]
-            );
-            $form->add('wysiwyg', "email[$blockId][signature_html]", ts('Signature (HTML)'),
-              ['rows' => 2, 'cols' => 40]
-            );
-          }
+      // Only display the signature fields if this contact has a CMS account
+      // because they can only send email if they have access to the CRM
+      $isAddSignatureFields = $form instanceof \CRM_Contact_Form_Contact && !empty($form->_contactId);
+      $form->assign('isAddSignatureFields', $isAddSignatureFields);
+      if ($isAddSignatureFields) {
+        $ufID = CRM_Core_BAO_UFMatch::getUFId($form->_contactId);
+        if ($ufID) {
+          $form->add('textarea', "email[$blockId][signature_text]", ts('Signature (Text)'),
+            ['rows' => 2, 'cols' => 40]
+          );
+          $form->add('wysiwyg', "email[$blockId][signature_html]", ts('Signature (HTML)'),
+            ['rows' => 2, 'cols' => 40]
+          );
         }
       }
     }

diff --git a/templates/CRM/Contact/Form/Edit/Email.tpl b/templates/CRM/Contact/Form/Edit/Email.tpl
@@ -26,7 +26,7 @@
 
 <tr id="Email_Block_{$blockId}">
   <td>{$form.email.$blockId.email.html|crmAddClass:email}&nbsp;{$form.email.$blockId.location_type_id.html}
-    {if $className eq 'CRM_Contact_Form_Contact' and !empty($form.email.$blockId.signature_html.html)}
+    {if $isAddSignatureFields}
       <div class="clear"></div>
       <div class="email-signature crm-collapsible collapsed">
         <div class="collapsible-title">