Remove do-nothing code.

This code conditionally adds the field is_required to the array that already
contains the field is_required

CRM/Price/BAO/PriceSet.php

@@ -386,7 +386,7 @@ public static function getAssoc($withInactive = FALSE, $extendComponentName = FA
    * @param int $setID
    *   Price Set ID.
    * @param bool $required
-   *   Appears to have no effect based on reading the code.
+   *   Deprecated.
    * @param bool $doNotIncludeExpiredFields
    *   Should only fields where today's date falls within the valid range be returned?
    *
@@ -415,9 +415,6 @@ public static function getSetDetail($setID, $required = TRUE, $doNotIncludeExpir
       'visibility_id',
       'is_required',
     ];
-    if ($required == TRUE) {
-      $priceFields[] = 'is_required';
-    }
 
     // create select
     $select = 'SELECT ' . implode(',', $priceFields);