Fold function only called from one place into caller, deprecate

CRM/Contact/BAO/Contact/Utils.php

@@ -1009,7 +1009,8 @@ public static function updateGreeting($params) {
         }
       }
 
-      self::processGreetingTemplate($greetingString, [], $contactID, 'CRM_UpdateGreeting');
+      CRM_Utils_Token::replaceGreetingTokens($templateString, [], $contactID, 'CRM_UpdateGreeting', TRUE);
+      $templateString = CRM_Utils_String::parseOneOffStringThroughSmarty($templateString);
       $greetingString = CRM_Core_DAO::escapeString($greetingString);
       $cacheFieldQuery .= " WHEN {$contactID} THEN '{$greetingString}' ";
 
@@ -1115,11 +1116,14 @@ public static function getTokensRequiredForContactGreetings($contactParams) {
    * @param string $templateString
    *   The greeting template string with contact tokens + Smarty syntax.
    *
+   * @deprecated
+   *
    * @param array $contactDetails
    * @param int $contactID
    * @param string $className
    */
   public static function processGreetingTemplate(&$templateString, $contactDetails, $contactID, $className) {
+    CRM_Core_Error::deprecatedFunctionWarning('no replacement');
     CRM_Utils_Token::replaceGreetingTokens($templateString, $contactDetails, $contactID, $className, TRUE);
     $templateString = CRM_Utils_String::parseOneOffStringThroughSmarty($templateString);
   }