Merge pull request #23132 from eileenmcnaughton/imp

Remove unnecessary pass-by-ref
civicrm · Apr 9, 2022 · 7603932 · 7603932
2 parents 5ffc164 + 6d283eb
commit 7603932
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/CRM/Activity/Import/Parser.php b/CRM/Activity/Import/Parser.php
@@ -59,7 +59,7 @@ abstract class CRM_Activity_Import_Parser extends CRM_Import_Parser {
   public function run(
     array $fileName,
     $separator,
-    &$mapper,
+    $mapper,
     $skipColumnHeader = FALSE,
     $mode = self::MODE_PREVIEW,
     $onDuplicate = self::DUPLICATE_SKIP,

diff --git a/CRM/Contribute/Import/Parser/Contribution.php b/CRM/Contribute/Import/Parser/Contribution.php
@@ -152,7 +152,7 @@ public function __construct(&$mapperKeys, $mapperSoftCredit = [], $mapperPhoneTy
   public function run(
     $fileName,
     $separator,
-    &$mapper,
+    $mapper,
     $skipColumnHeader = FALSE,
     $mode = self::MODE_PREVIEW,
     $contactType = self::CONTACT_INDIVIDUAL,

diff --git a/CRM/Custom/Import/Parser.php b/CRM/Custom/Import/Parser.php
@@ -59,7 +59,7 @@ abstract class CRM_Custom_Import_Parser extends CRM_Import_Parser {
   public function run(
     $fileName,
     $separator,
-    &$mapper,
+    $mapper,
     $skipColumnHeader = FALSE,
     $mode = self::MODE_PREVIEW,
     $contactType = self::CONTACT_INDIVIDUAL,

diff --git a/CRM/Event/Import/Parser.php b/CRM/Event/Import/Parser.php
@@ -61,7 +61,7 @@ abstract class CRM_Event_Import_Parser extends CRM_Import_Parser {
   public function run(
     $fileName,
     $separator,
-    &$mapper,
+    $mapper,
     $skipColumnHeader = FALSE,
     $mode = self::MODE_PREVIEW,
     $contactType = self::CONTACT_INDIVIDUAL,

diff --git a/CRM/Import/Form/DataSource.php b/CRM/Import/Form/DataSource.php
@@ -150,7 +150,7 @@ protected function submitFileForMapping($parserClassName, $entity = NULL) {
     $parser->setMaxLinesToProcess(100);
     $parser->run($fileName,
       $separator,
-      $mapper,
+      [],
       $skipColumnHeader,
       CRM_Import_Parser::MODE_MAPFIELD,
       $this->get('contactType')