Set contribution_page_id from template contribution

This is tested in AuthorizeNetIPNTest::testIPNPaymentRecurNoReceipt
civicrm · Jan 11, 2021 · 6c3e774 · 6c3e774
1 parent df1fc58
commit 6c3e774
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/CRM/Contribute/BAO/Contribution.php b/CRM/Contribute/BAO/Contribution.php
@@ -2442,7 +2442,7 @@ protected static function repeatTransaction(&$contribution, $input, $contributio
       else {
         $contributionParams['financial_type_id'] = $templateContribution['financial_type_id'];
       }
-      foreach (['contact_id', 'currency', 'source', 'amount_level', 'address_id', 'on_behalf', 'source_contact_id', 'tax_amount'] as $fieldName) {
+      foreach (['contact_id', 'currency', 'source', 'amount_level', 'address_id', 'on_behalf', 'source_contact_id', 'tax_amount', 'contribution_page_id'] as $fieldName) {
         if (isset($templateContribution[$fieldName])) {
           $contributionParams[$fieldName] = $templateContribution[$fieldName];
         }

diff --git a/CRM/Core/Payment.php b/CRM/Core/Payment.php
@@ -1212,7 +1212,7 @@ public function getCancelUrl($qfKey, $participantID) {
   /**
    * Get URL to return the browser to on success.
    *
-   * @param $qfKey
+   * @param string $qfKey
    *
    * @return string
    */

diff --git a/CRM/Core/Payment/AuthorizeNetIPN.php b/CRM/Core/Payment/AuthorizeNetIPN.php
@@ -84,9 +84,6 @@ public function main() {
         //load new contribution object if required.
         // create a contribution and then get it processed
         $contribution = new CRM_Contribute_BAO_Contribution();
-        $contribution->contribution_page_id = $ids['contributionPage'];
-        $contribution->contribution_recur_id = $ids['contributionRecur'];
-        $contribution->receive_date = $input['receive_date'];
       }
       $input['payment_processor_id'] = $paymentProcessorID;
       $isFirstOrLastRecurringPayment = $this->recur($input, $contributionRecur, $contribution, $first);