Skip to content

Commit

Permalink
dev/core#2769 use php email validation not hacked qf
Browse files Browse the repository at this point in the history
Per https://lab.civicrm.org/dev/core/-/issues/2769 we have had problems over the years with
quickform's email validation and we now have a hacked version that is
problematic from a maintenance pov & also doesn't work
with the string I have just encountered: name.-o-.i.10@example.com
(which I am told is valid and which passes the php filter).

We already have an email rule which calls a php native function
which is better maintained than our layers of hacks. This
PR registers our email rule - which overrides the quickform
one. If we merge this we can revert quickform back to
unhacked which will improve debugging
and maintenance (although it's actually bypassed
now with this change)
  • Loading branch information
eileenmcnaughton committed Aug 17, 2021
1 parent 613f5b0 commit 6792e35
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions CRM/Core/Form.php
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,7 @@ public function registerRules() {
'settingPath',
'autocomplete',
'validContact',
'email',
];

foreach ($rules as $rule) {
Expand Down

0 comments on commit 6792e35

Please sign in to comment.