[PHPunit8] cleanup on tearDown functions

tests/phpunit/CRM/ACL/ListTest.php

@@ -13,7 +13,7 @@ class CRM_ACL_ListTest extends CiviUnitTestCase {
   /**
    * Set up function.
    */
-  public function setUp() {
+  public function setUp(): void {
     parent::setUp();
     // $this->quickCleanup(array('civicrm_acl_contact_cache'), TRUE);
     $this->useTransaction(TRUE);

tests/phpunit/CRM/Activity/BAO/ActivityTest.php

@@ -17,7 +17,7 @@ class CRM_Activity_BAO_ActivityTest extends CiviUnitTestCase {
    *
    * @throws \CiviCRM_API3_Exception
    */
-  public function setUp() {
+  public function setUp():void {
     parent::setUp();
     $this->prepareForACLs();
     CRM_Core_Config::singleton()->userPermissionClass->permissions = ['view all contacts', 'access CiviCRM'];

tests/phpunit/CRM/Activity/Form/ActivityTest.php

@@ -8,7 +8,7 @@
  */
 class CRM_Activity_Form_ActivityTest extends CiviUnitTestCase {
 
-  public function setUp() {
+  public function setUp():void {
     parent::setUp();
     $this->assignee1 = $this->individualCreate([
       'first_name' => 'testassignee1',

tests/phpunit/CRM/Activity/Form/SearchTest.php

@@ -6,7 +6,7 @@
  */
 class CRM_Activity_Form_SearchTest extends CiviUnitTestCase {
 
-  public function setUp() {
+  public function setUp(): void {
     parent::setUp();
     $this->individualID = $this->individualCreate();
     $this->contributionCreate([

tests/phpunit/CRM/Activity/Page/AJAXTest.php

@@ -5,7 +5,7 @@
  */
 class CRM_Activity_Page_AJAXTest extends CiviUnitTestCase {
 
-  public function setUp() {
+  public function setUp(): void {
     parent::setUp();
 
     $this->loadAllFixtures();

tests/phpunit/CRM/Batch/Form/EntryTest.php

@@ -75,7 +75,7 @@ class CRM_Batch_Form_EntryTest extends CiviUnitTestCase {
    */
   protected $_contactID4 = NULL;
 
-  public function setUp() {
+  public function setUp(): void {
     parent::setUp();
 
     $params = [

tests/phpunit/CRM/Case/BAO/CaseTest.php

@@ -6,7 +6,7 @@
  */
 class CRM_Case_BAO_CaseTest extends CiviUnitTestCase {
 
-  public function setUp() {
+  public function setUp(): void {
     parent::setUp();
 
     $this->tablesToTruncate = [

tests/phpunit/CRM/Case/BAO/CaseTypeForkTest.php

@@ -7,7 +7,7 @@
  */
 class CRM_Case_BAO_CaseTypeForkTest extends CiviCaseTestCase {
 
-  public function setUp() {
+  public function setUp(): void {
     parent::setUp();
     CRM_Core_ManagedEntities::singleton(TRUE)->reconcile();
   }

tests/phpunit/CRM/Case/Form/CustomDataTest.php

@@ -9,7 +9,7 @@ class CRM_Case_Form_CustomDataTest extends CiviCaseTestCase {
 
   protected $custom_group;
 
-  public function setUp() {
+  public function setUp(): void {
     parent::setUp();
     $this->custom_group = $this->customGroupCreate(['extends' => 'Case']);
     $this->custom_group = $this->custom_group['values'][$this->custom_group['id']];

tests/phpunit/CRM/Case/Form/SearchTest.php

@@ -7,7 +7,7 @@
  */
 class CRM_Case_Form_SearchTest extends CiviCaseTestCase {
 
-  public function setUp() {
+  public function setUp():void {
     parent::setUp();
     $this->quickCleanup(['civicrm_case_contact', 'civicrm_case', 'civicrm_contact']);
   }

tests/phpunit/CRM/Case/XMLProcessor/ProcessTest.php

@@ -7,7 +7,7 @@
  */
 class CRM_Case_XMLProcessor_ProcessTest extends CiviCaseTestCase {
 
-  public function setUp() {
+  public function setUp(): void {
     parent::setUp();
 
     $this->defaultAssigneeOptionsValues = [];

tests/phpunit/CRM/Case/XMLProcessor/ReportTest.php

@@ -7,7 +7,7 @@
  */
 class CRM_Case_XMLProcessor_ReportTest extends CiviCaseTestCase {
 
-  public function setUp() {
+  public function setUp(): void {
     parent::setUp();
 
     $this->simplifyCaseTypeDefinition();

tests/phpunit/CRM/Case/XMLProcessorTest.php

@@ -7,7 +7,7 @@
  */
 class CRM_Case_XMLProcessorTest extends CiviCaseTestCase {
 
-  public function setUp() {
+  public function setUp(): void {
     parent::setUp();
 
     $this->processor = new CRM_Case_XMLProcessor();

tests/phpunit/CRM/Case/XMLRepositoryTest.php

@@ -7,7 +7,7 @@
 class CRM_Case_XMLRepositoryTest extends CiviUnitTestCase {
   protected $fixtures = [];
 
-  protected function setUp() {
+  protected function setUp(): void {
     parent::setUp();
     $this->fixtures['CaseTypeWithSingleActivityType'] = '
 <CaseType>

tests/phpunit/CRM/Contact/BAO/ActivitySearchTest.php

@@ -52,7 +52,7 @@ class CRM_Contact_BAO_ActivitySearchTest extends CiviUnitTestCase {
    * Connect to the database, truncate the tables that will be used
    * and redirect stdin to a temporary file
    */
-  public function setUp() {
+  public function setUp(): void {
     // Connect to the database
     parent::setUp();
 

tests/phpunit/CRM/Contact/BAO/ContactTest.php

@@ -6,13 +6,6 @@
  */
 class CRM_Contact_BAO_ContactTest extends CiviUnitTestCase {
 
-  /**
-   * Set up function.
-   */
-  public function setUp() {
-    parent::setUp();
-  }
-
   /**
    * Test case for add( ).
    *

tests/phpunit/CRM/Contact/BAO/ContactType/ContactSearchTest.php

@@ -6,7 +6,7 @@
  */
 class CRM_Contact_BAO_ContactType_ContactSearchTest extends CiviUnitTestCase {
 
-  public function setUp() {
+  public function setUp(): void {
     parent::setUp();
     $students = 'indivi_student' . substr(sha1(rand()), 0, 7);
     $params = [

tests/phpunit/CRM/Contact/BAO/ContactType/ContactTest.php

@@ -6,7 +6,7 @@
  */
 class CRM_Contact_BAO_ContactType_ContactTest extends CiviUnitTestCase {
 
-  public function setUp() {
+  public function setUp(): void {
     parent::setUp();
 
     $params = [

tests/phpunit/CRM/Contact/BAO/ContactType/ContactTypeTest.php

@@ -7,7 +7,7 @@
  */
 class CRM_Contact_BAO_ContactType_ContactTypeTest extends CiviUnitTestCase {
 
-  public function setUp() {
+  public function setUp(): void {
     parent::setUp();
     $params = [
       'label' => 'sub1_individual',

tests/phpunit/CRM/Contact/BAO/ContactType/RelationshipTest.php

@@ -6,7 +6,7 @@
  */
 class CRM_Contact_BAO_ContactType_RelationshipTest extends CiviUnitTestCase {
 
-  public function setUp() {
+  public function setUp(): void {
     parent::setUp();
 
     //create contact subtypes

tests/phpunit/CRM/Contact/BAO/GroupContactCacheTest.php

@@ -245,16 +245,6 @@ public function testJobWrapper() {
    */
   private $_testObjects;
 
-  /**
-   * Sets up the fixture, for example, opens a network connection.
-   *
-   * This method is called before a test is executed.
-   */
-  protected function setUp() {
-    $this->_testObjects = [];
-    parent::setUp();
-  }
-
   /**
    * Tears down the fixture, for example, closes a network connection.
    *

tests/phpunit/CRM/Contact/BAO/GroupTest.php

@@ -17,15 +17,6 @@
  */
 class CRM_Contact_BAO_GroupTest extends CiviUnitTestCase {
 
-  /**
-   * Sets up the fixture, for example, opens a network connection.
-   *
-   * This method is called before a test is executed.
-   */
-  protected function setUp() {
-    parent::setUp();
-  }
-
   /**
    * Tears down the fixture, for example, closes a network connection.
    *

tests/phpunit/CRM/Contact/BAO/QueryTest.php

@@ -17,10 +17,6 @@ public function dataProvider() {
     return new CRM_Contact_BAO_QueryTestDataProvider();
   }
 
-  public function setUp() {
-    parent::setUp();
-  }
-
   /**
    * Clean up after test.
    *

tests/phpunit/CRM/Contact/BAO/RelationshipCacheTest.php

@@ -17,7 +17,7 @@
  */
 class CRM_Contact_BAO_RelationshipCacheTest extends CiviUnitTestCase {
 
-  protected function setUp() {
+  protected function setUp(): void {
     $this->useTransaction(TRUE);
     parent::setUp();
   }

tests/phpunit/CRM/Contact/BAO/RelationshipTest.php

@@ -17,15 +17,6 @@
  */
 class CRM_Contact_BAO_RelationshipTest extends CiviUnitTestCase {
 
-  /**
-   * Sets up the fixture, for example, opens a network connection.
-   *
-   * This method is called before a test is executed.
-   */
-  protected function setUp() {
-    parent::setUp();
-  }
-
   /**
    * Tears down the fixture, for example, closes a network connection.
    *

tests/phpunit/CRM/Contribute/BAO/ContributionTypeTest.php

@@ -15,7 +15,7 @@
  */
 class CRM_Contribute_BAO_ContributionTypeTest extends CiviUnitTestCase {
 
-  public function setUp() {
+  public function setUp(): void {
     parent::setUp();
     $this->organizationCreate();
   }

tests/phpunit/CRM/Contribute/BAO/ProductTest.php

@@ -15,10 +15,6 @@
  */
 class CRM_Contribute_BAO_ProductTest extends CiviUnitTestCase {
 
-  public function setUp() {
-    parent::setUp();
-  }
-
   /**
    * Check method add()
    */

tests/phpunit/CRM/Extension/Manager/ModuleTest.php

@@ -6,7 +6,7 @@
  */
 class CRM_Extension_Manager_ModuleTest extends CiviUnitTestCase {
 
-  public function setUp() {
+  public function setUp():void {
     parent::setUp();
     // $query = "INSERT INTO civicrm_domain ( name, version ) VALUES ( 'domain', 3 )";
     // $result = CRM_Core_DAO::executeQuery($query);

tests/phpunit/CRM/Extension/Manager/ReportTest.php

@@ -6,7 +6,7 @@
  */
 class CRM_Extension_Manager_ReportTest extends CiviUnitTestCase {
 
-  public function setUp() {
+  public function setUp(): void {
     parent::setUp();
     //if (class_exists('test_extension_manager_reporttest')) {
     //  test_extension_manager_reporttest::$counts = array();
@@ -17,10 +17,6 @@ public function setUp() {
     ]);
   }
 
-  public function tearDown() {
-    parent::tearDown();
-  }
-
   /**
    * Install an extension with a valid type name.
    */

tests/phpunit/CRM/Extension/ManagerTest.php

@@ -17,16 +17,12 @@ class CRM_Extension_ManagerTest extends CiviUnitTestCase {
   const TESTING_TYPE = 'report';
   const OTHER_TESTING_TYPE = 'module';
 
-  public function setUp() {
+  public function setUp(): void {
     parent::setUp();
     list ($this->basedir, $this->container) = $this->_createContainer();
     $this->mapper = new CRM_Extension_Mapper($this->container);
   }
 
-  public function tearDown() {
-    parent::tearDown();
-  }
-
   /**
    * Install an extension with an invalid type name.
    *

tests/phpunit/CRM/Extension/MapperTest.php

@@ -36,7 +36,7 @@ class CRM_Extension_MapperTest extends CiviUnitTestCase {
    */
   protected $mapperWithSlash;
 
-  public function setUp() {
+  public function setUp(): void {
     parent::setUp();
     list ($this->basedir, $this->container) = $this->_createContainer();
     $this->mapper = new CRM_Extension_Mapper($this->container);
@@ -45,10 +45,6 @@ public function setUp() {
     $this->mapperWithSlash = new CRM_Extension_Mapper($this->containerWithSlash);
   }
 
-  public function tearDown() {
-    parent::tearDown();
-  }
-
   public function testClassToKey() {
     $this->assertEquals("test.foo.bar", $this->mapper->classToKey('test_foo_bar'));
   }

tests/phpunit/CRM/Financial/Form/PaymentEditTest.php

@@ -19,7 +19,7 @@ class CRM_Financial_Form_PaymentEditTest extends CiviUnitTestCase {
   /**
    * Setup function.
    */
-  public function setUp() {
+  public function setUp(): void {
     parent::setUp();
     $this->createLoggedInUser();
 

tests/phpunit/CRM/Pledge/BAO/PledgeBlockTest.php

@@ -21,19 +21,12 @@ class CRM_Pledge_BAO_PledgeBlockTest extends CiviUnitTestCase {
    * Sets up the fixture, for example, opens a network connection.
    * This method is called before a test is executed.
    */
-  protected function setUp() {
+  protected function setUp(): void {
     parent::setUp();
     $contributionPage = $this->contributionPageCreate();
     $this->_contributionPageId = $contributionPage['id'];
   }
 
-  /**
-   * Tears down the fixture, for example, closes a network connection.
-   * This method is called after a test is executed.
-   */
-  protected function tearDown() {
-  }
-
   /**
    *  create() and deletepledgeblock() method
    */

tests/phpunit/CRM/Pledge/BAO/PledgePaymentTest.php

@@ -17,21 +17,6 @@
  */
 class CRM_Pledge_BAO_PledgePaymentTest extends CiviUnitTestCase {
 
-  /**
-   * Sets up the fixture, for example, opens a network connection.
-   * This method is called before a test is executed.
-   */
-  protected function setUp() {
-    parent::setUp();
-  }
-
-  /**
-   * Tears down the fixture, for example, closes a network connection.
-   * This method is called after a test is executed.
-   */
-  protected function tearDown() {
-  }
-
   /**
    *  Test for Add/Update Pledge Payment.
    */