Merge pull request #26165 from larssandergreen/php-warning-for-add-to…

…-group Fix PHP8 warnings for AddToGroup
civicrm · May 7, 2023 · 5747d3f · 5747d3f
2 parents 665eb3a + 008a175
commit 5747d3f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/CRM/Contact/Form/Task/AddToGroup.php b/CRM/Contact/Form/Task/AddToGroup.php
@@ -109,10 +109,6 @@ public function buildQuickForm() {
 
     if ($this->_context === 'amtg') {
       $groupElement->freeze();
-
-      // also set the group title
-      $groupValues = ['id' => $this->_id, 'title' => $this->_title];
-      $this->assign_by_ref('group', $groupValues);
     }
 
     // Set dynamic page title for 'Add Members Group (confirm)'

diff --git a/templates/CRM/Contact/Form/Task/AddToGroup.tpl b/templates/CRM/Contact/Form/Task/AddToGroup.tpl
@@ -9,7 +9,7 @@
 *}
 <div class="crm-block crm-form-block crm-contact-task-addtogroup-form-block">
 <table class="form-layout">
-    {if $group.id}
+    {if $form.group_id.value}
        <tr class="crm-contact-task-addtogroup-form-block-group_id">
           <td class="label">{ts}Group{/ts}</td>
           <td>{$form.group_id.html}</td>
@@ -54,7 +54,7 @@
 </div>
 {include file="CRM/common/showHide.tpl"}
 
-{if !$group.id}
+{if !$form.group_id.value}
 {literal}
 <script type="text/javascript">
 showElements();