Merge pull request #17596 from eileenmcnaughton/deprecation

dev/financial#131 Give deprecation notice if the payment processor returns an error

CRM/Core/Payment.php

@@ -1375,6 +1375,7 @@ public function doPayment(&$params, $component = 'contribute') {
       }
     }
     if (is_a($result, 'CRM_Core_Error')) {
+      CRM_Core_Error::deprecatedFunctionWarning('payment processors should throw exceptions rather than return errors');
       throw new PaymentProcessorException(CRM_Core_Error::getMessages($result));
     }
     return $result;