Merge pull request #22544 from colemanw/deconstructor

(REF) Remove constructors that do nothing
civicrm · Jan 17, 2022 · 485427d · 485427d
2 parents 47b64be + 3e416f2
commit 485427d
Show file tree

Hide file tree

Showing 8 changed files with 1 addition and 64 deletions.
diff --git a/CRM/Contact/Page/View/CustomData.php b/CRM/Contact/Page/View/CustomData.php
@@ -27,15 +27,6 @@ class CRM_Contact_Page_View_CustomData extends CRM_Core_Page {
    */
   public $_groupId;
 
-  /**
-   * Class constructor.
-   *
-   * @return CRM_Contact_Page_View_CustomData
-   */
-  public function __construct() {
-    parent::__construct();
-  }
-
   /**
    * Add a few specific things to view contact.
    */

diff --git a/CRM/Contribute/BAO/ContributionSoft.php b/CRM/Contribute/BAO/ContributionSoft.php
@@ -18,13 +18,6 @@
  */
 class CRM_Contribute_BAO_ContributionSoft extends CRM_Contribute_DAO_ContributionSoft {
 
-  /**
-   * Construct method.
-   */
-  public function __construct() {
-    parent::__construct();
-  }
-
   /**
    * Add contribution soft credit record.
    *

diff --git a/CRM/Core/BAO/FinancialTrxn.php b/CRM/Core/BAO/FinancialTrxn.php
@@ -15,17 +15,6 @@
  * @copyright CiviCRM LLC https://civicrm.org/licensing
  */
 class CRM_Core_BAO_FinancialTrxn extends CRM_Financial_DAO_FinancialTrxn {
-  /**
-   * Class constructor.
-   *
-   * @return \CRM_Financial_DAO_FinancialTrxn
-   */
-
-  /**
-   */
-  public function __construct() {
-    parent::__construct();
-  }
 
   /**
    * Takes an associative array and creates a financial transaction object.

diff --git a/CRM/Core/Config.php b/CRM/Core/Config.php
@@ -66,14 +66,6 @@ class CRM_Core_Config extends CRM_Core_Config_MagicMerge {
    */
   private static $_singleton = NULL;
 
-  /**
-   * The constructor. Sets domain id if defined, otherwise assumes
-   * single instance installation.
-   */
-  public function __construct() {
-    parent::__construct();
-  }
-
   /**
    * Singleton function used to manage this object.
    *

diff --git a/CRM/Core/Smarty.php b/CRM/Core/Smarty.php
@@ -63,15 +63,6 @@ class CRM_Core_Smarty extends Smarty {
    */
   private $backupFrames = [];
 
-  /**
-   * Class constructor.
-   *
-   * @return CRM_Core_Smarty
-   */
-  public function __construct() {
-    parent::__construct();
-  }
-
   private function initialize() {
     $config = CRM_Core_Config::singleton();
 

diff --git a/CRM/Event/BAO/Participant.php b/CRM/Event/BAO/Participant.php
@@ -44,12 +44,6 @@ class CRM_Event_BAO_Participant extends CRM_Event_DAO_Participant {
     'Pending from approval' => ['Registered', 'Cancelled'],
   ];
 
-  /**
-   */
-  public function __construct() {
-    parent::__construct();
-  }
-
   /**
    * Takes an associative array and creates a participant object.
    *

diff --git a/CRM/Friend/BAO/Friend.php b/CRM/Friend/BAO/Friend.php
@@ -28,12 +28,6 @@ class CRM_Friend_BAO_Friend extends CRM_Friend_DAO_Friend {
    */
   public $_friendId;
 
-  /**
-   */
-  public function __construct() {
-    parent::__construct();
-  }
-
   /**
    * Takes an associative array and creates a friend object.
    *

diff --git a/CRM/Mailing/BAO/BouncePattern.php b/CRM/Mailing/BAO/BouncePattern.php
@@ -22,13 +22,6 @@ class CRM_Mailing_BAO_BouncePattern extends CRM_Mailing_DAO_BouncePattern {
    */
   public static $_patterns = NULL;
 
-  /**
-   * Class constructor.
-   */
-  public function __construct() {
-    parent::__construct();
-  }
-
   /**
    * Build the static pattern array.
    */
@@ -60,7 +53,7 @@ public static function buildPatterns() {
    * @return array
    *   Tuple (bounce_type, bounce_reason)
    */
-  public static function &match(&$message) {
+  public static function match($message) {
     // clean up $message and replace all white space by a single space, CRM-4767
     $message = preg_replace('/\s+/', ' ', $message);