Skip to content

Commit

Permalink
Merge pull request #15866 from eileenmcnaughton/test_dumb
Browse files Browse the repository at this point in the history
[NFC] [Test-only] Remove partially paid from statuses tested for RenewContribution
  • Loading branch information
mattwire authored Nov 18, 2019
2 parents bb9b0a9 + 23c6478 commit 3d6d5be
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions tests/phpunit/api/v3/ContributionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -2364,11 +2364,14 @@ public function testRepeatTransactionMembershipRenewCompletedContribution() {
* CRM-19945 Tests that Contribute.repeattransaction DOES NOT renew a membership when contribution status=Failed
*
* @dataProvider contributionStatusProvider
*
* @throws \CRM_Core_Exception
*/
public function testRepeatTransactionMembershipRenewContributionNotCompleted($contributionStatus) {
// Completed status should renew so we don't test that here
// In Progress status is only for recurring contributions so we don't test that here
if (in_array($contributionStatus['name'], ['Completed', 'In Progress'])) {
// In Progress status was never actually intended to be available for contributions.
// Partially paid is not valid.
if (in_array($contributionStatus['name'], ['Completed', 'In Progress', 'Partially paid'])) {
return;
}
list($originalContribution, $membership) = $this->setUpAutoRenewMembership();
Expand Down

0 comments on commit 3d6d5be

Please sign in to comment.