Merge pull request #12596 from eileenmcnaughton/export_ref

[NFC] Export - don't pass arrays as reference when they are not changed
civicrm · Jul 30, 2018 · 315dbc2 · 315dbc2
2 parents 771c671 + 610f72e
commit 315dbc2
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/CRM/Export/BAO/Export.php b/CRM/Export/BAO/Export.php
@@ -796,7 +796,7 @@ public static function sqlColumnDefn($processor, &$sqlColumns, $field) {
    * @param $details
    * @param $sqlColumns
    */
-  public static function writeDetailsToTable($tableName, &$details, &$sqlColumns) {
+  public static function writeDetailsToTable($tableName, $details, $sqlColumns) {
     if (empty($details)) {
       return;
     }
@@ -813,10 +813,10 @@ public static function writeDetailsToTable($tableName, &$details, &$sqlColumns)
 
     $sqlClause = array();
 
-    foreach ($details as $dontCare => $row) {
+    foreach ($details as $row) {
       $id++;
       $valueString = array($id);
-      foreach ($row as $dontCare => $value) {
+      foreach ($row as $value) {
         if (empty($value)) {
           $valueString[] = "''";
         }
@@ -843,7 +843,7 @@ public static function writeDetailsToTable($tableName, &$details, &$sqlColumns)
    *
    * @return string
    */
-  public static function createTempTable(&$sqlColumns) {
+  public static function createTempTable($sqlColumns) {
     //creating a temporary table for the search result that need be exported
     $exportTempTable = CRM_Utils_SQL_TempTable::build()->setDurable()->setCategory('export')->getName();