Merge pull request #9722 from eileenmcnaughton/comments

Comment fixes plus fix inconsistent unused return bool
civicrm · Jan 25, 2017 · 131ec23 · 131ec23
2 parents d33b6fe + 2ea4879
commit 131ec23
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CRM/Core/BAO/FinancialTrxn.php b/CRM/Core/BAO/FinancialTrxn.php
@@ -598,7 +598,7 @@ public static function getMembershipRevenueAmount($lineItem) {
    *
    * @param array $lineItems
    *
-   * @param array $contributionDetails
+   * @param CRM_Contribute_BAO_Contribution $contributionDetails
    *
    * @param bool $update
    *
@@ -607,7 +607,7 @@ public static function getMembershipRevenueAmount($lineItem) {
    */
   public static function createDeferredTrxn($lineItems, $contributionDetails, $update = FALSE, $context = NULL) {
     if (empty($lineItems)) {
-      return FALSE;
+      return;
     }
     $revenueRecognitionDate = $contributionDetails->revenue_recognition_date;
     if (!CRM_Utils_System::isNull($revenueRecognitionDate)) {

diff --git a/CRM/Event/Form/Task/Batch.php b/CRM/Event/Form/Task/Batch.php
@@ -507,6 +507,8 @@ public static function updateContributionStatus($params) {
     }
 
     //complete the contribution.
+    // @todo use the api - ie civicrm_api3('Contribution', 'completetransaction', $input);
+    // as this method is not preferred / supported.
     $baseIPN->completeTransaction($input, $ids, $objects, $transaction, FALSE);
 
     // reset template values before processing next transactions