Merge pull request #25343 from braders/local-variables-pricefieldvalu…

…etest

[REF][PHP8.2] Move to standard varaibles in CRM_Price_BAO_PriceFieldValueTest to avoid dynamic properties

tests/phpunit/CRM/Price/BAO/PriceFieldValueTest.php

@@ -41,26 +41,26 @@ public function testEmptyStringLabel() {
     ];
 
     $price_set = $this->callAPISuccess('price_set', 'create', $priceSetParams);
-    $this->priceSetID = $price_set['id'];
+    $priceSetID = $price_set['id'];
 
     $priceFieldParams = [
-      'price_set_id' => $this->priceSetID,
+      'price_set_id' => $priceSetID,
       'name' => 'grassvariety',
       'label' => 'Grass Variety',
       'html_type' => 'Text',
       'is_enter_qty' => 1,
       'is_active' => 1,
     ];
     $priceField = $this->callAPISuccess('price_field', 'create', $priceFieldParams);
-    $this->priceFieldID = $priceField['id'];
-    $this->_params = [
-      'price_field_id' => $this->priceFieldID,
+    $priceFieldID = $priceField['id'];
+    $params = [
+      'price_field_id' => $priceFieldID,
       'name' => 'rye_grass',
       'label' => '',
       'amount' => 1,
       'financial_type_id' => 1,
     ];
-    $priceFieldValue = CRM_Price_BAO_PriceFieldValue::create($this->_params);
+    $priceFieldValue = CRM_Price_BAO_PriceFieldValue::create($params);
     $priceFieldValue->find(TRUE);
     $this->assertEquals('', $priceFieldValue->label);
   }