Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drupal-* - Use 'civicrm_install_transitional' #750

Merged
merged 2 commits into from
Jan 3, 2023

Conversation

totten
Copy link
Member

@totten totten commented Dec 20, 2022

In #735, the build scripts for drupal-clean and drupal-demo switched:

  • From: civicrm_install (ie setup.sh)
  • To: civicrm_install_cv (ie cv core:install)

I drafted this as a possible work-around for the failures in 5.51 on https://test.civicrm.org/job/CiviCRM-Civix-Matrix/ -- but still checking to see if it actually helps.

(The PR also goes a bit further, and extends the use of civicrm_install_cv to a few more build-types.)

…CiviCRM (<5.57)

This extracts a method `civicrm_install_transitional`. It is a wrapper which conditionally
calls `civicrm_install` or `civicrm_install_cv`.
@totten
Copy link
Member Author

totten commented Dec 20, 2022

Erg. So apparently the failure that I'm looking at is specific to 5.51 and extension-testing.

  • It doesn't involve the installer per se (switching among civicrm_install / civicrm_install_cv / civicrm_install_transitional doesn't help).
  • It presents as a fatal error involving SearchSegment and SpecGatherer.
  • It affects both CiviCRM-Core-Matrix (phpunit-core-exts, example) and CiviCRM-Civix-Matrix (example).
  • When you switch to any other version (5.45, 5.50, 5.52, etc), those same test-suites run fine.

@totten
Copy link
Member Author

totten commented Dec 20, 2022

OK, the SearchSegment problem was specifically fixed in 5.52 (civicrm/civicrm-core#23991). I've added a backport for 5.51-esr and hacked CiviCRM-Civix-Matrix to include the backport (which appears to be working).

@totten
Copy link
Member Author

totten commented Jan 3, 2023

This ultimately wasn't needed to fix CiviCRM-Civix-Matrix, but I think it's better to include it (e.g. switches a few more configurations; e.g. more accurate representation of how builds worked for older versions; e.g. better model for subsequent updates to backdrop-* configurations).

@totten totten merged commit 83f04db into civicrm:master Jan 3, 2023
@totten totten deleted the master-installer branch January 3, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant