Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/config/drupal-clean - Use CV for installation #673

Closed
wants to merge 3 commits into from

Conversation

totten
Copy link
Member

@totten totten commented Feb 16, 2022

Rebased/reopened @seamuslee001's #661.

@seamuslee001 I tried the changes out locally and found an issue.

civibuild create tmp --type drupal-clean
civi-test-run -b tmp -j /tmp/junit phpunit-e2e

This gave several errors in tests/phpunit/E2E/Extern/*, eg

E2E_Extern_LegacyRestTest::testAPICalls with data set #0 (array('Contact', 'get', 'pakK68PIjWzYIMG3', '1'), 1)

        (
            [entity] => Contact
            [action] => get
            [key] => pakK68PIjWzYIMG3
            [json] => 1
        )

    [response data] => ...(SNIP-HTML)...
Fatal error: require_once(): Failed opening required '../civicrm.config.php' (include_path='.:/nix/store/0jjkqmqgf80ww3gvch8jwcgmknmvfn8x-php-7.2.23/lib/php') in /home/totten/bknix/build/tmp/web/sites/all/modules/civicrm/extern/rest.php on line
...(SNIP-HTML)...
)

This makes sense - as we discussed on #661, it was skipping setup.sh completely. So I threw in a lighter call (setup.sh -g), and now it seems good with civi-test-run ... phpunit-e2e.

I'm having trouble, though, with civi-test-run ... karma. I think that's something with my workstation (55/81 tests fail - on both master and drupal_clean_install-cv), so it might help if you tried it too.

@github-actions
Copy link

This pull request has reached 30 days with no activity, it has been marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants